Skip to content

DateRangePicker - Add cancel button in dialog mode #16109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChronosSF merged 12 commits into from
Aug 22, 2025
Merged

DateRangePicker - Add cancel button in dialog mode #16109

ChronosSF merged 12 commits into from
Aug 22, 2025

Conversation

@IvanKitanov17
Copy link
Contributor

@IvanKitanov17 IvanKitanov17 commented Aug 1, 2025

Closes #16091

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@IvanKitanov17 IvanKitanov17 requested a review from ChronosSF August 5, 2025 12:50
ChronosSF
ChronosSF reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@ChronosSF ChronosSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry for this

@ChronosSF ChronosSF self-requested a review August 19, 2025 14:04
ChronosSF
ChronosSF previously approved these changes Aug 19, 2025
View reviewed changes
@MonikaKirkova MonikaKirkova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Aug 20, 2025
@ChronosSF ChronosSF self-requested a review August 21, 2025 12:34
ChronosSF
ChronosSF previously approved these changes Aug 21, 2025
View reviewed changes
@ChronosSF ChronosSF merged commit dbf466a into master Aug 22, 2025
5 of 7 checks passed
@ChronosSF ChronosSF deleted the ikitanov/fix-16091 branch August 22, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

Assignees

@MonikaKirkova MonikaKirkova

Labels

📈 enhancement 📅 date-range-picker ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Date Range Picker] Add cancel button to dialog in dialog mode

6 participants

@IvanKitanov17 @ChronosSF @MonikaKirkova @kacheshmarova @Lipata